Fix support for mixing react-dom/server@16.6 and react@<16.6 #14291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
approved these changes
Nov 20, 2018
|
Is this slower now? Please add a follow up task to make it faster again. Does it prevent inlining (by making the generated to code larger)? This was very intentional minimal code. |
|
The idea here is that it should just do a hidden class check, then put the current value in the register and jump over it with the same label as it would use for the loop. Thereby making this code inline-friendly (in the VM). This check would add additional logic that at least deals with the other case and might need more registers. |
|
Isn’t this DEV only? |
|
Doh. I misread the DEV closing brace. 😳 |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an obscure issue if you use
react-dom/serverfrom 16.6 butreactfrom 16.5 or earlier. We decided to support this a while ago and it's easy to keep working.I didn't bother writing a test because I'm lazy.